Closed kosuke316 closed 3 years ago
Merging #873 into master will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #873 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 1809 1810 +1
Branches 312 312
=========================================
+ Hits 1809 1810 +1
Impacted Files | Coverage Δ | |
---|---|---|
arrow/locales.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1b12fb2...e7d9e1a. Read the comment docs.
@kosuke316 Thank you for contributing and correcting the locale!
The tests do seem to be passing, but I noticed there are no Japanese locale tests. Would you like to add that to your pull request?
@krisfremen Thanks for the reply! I've also added a test feature. I hope you can check it out.
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
tox
ormake test
to find out!).tox -e lint
ormake lint
to find out!).master
branch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes