Closed jadchaar closed 3 years ago
Merging #877 (6fc80d9) into master (609b630) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #877 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 1810 1796 -14
Branches 312 313 +1
=========================================
- Hits 1810 1796 -14
Impacted Files | Coverage Δ | |
---|---|---|
arrow/api.py | 100.00% <ø> (ø) |
|
arrow/arrow.py | 100.00% <100.00%> (ø) |
|
arrow/constants.py | 100.00% <100.00%> (ø) |
|
arrow/factory.py | 100.00% <100.00%> (ø) |
|
arrow/formatter.py | 100.00% <100.00%> (ø) |
|
arrow/locales.py | 100.00% <100.00%> (ø) |
|
arrow/parser.py | 100.00% <100.00%> (ø) |
|
arrow/util.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 609b630...6fc80d9. Read the comment docs.
Should be ready for review @systemcatch @krisfremen. All what remains is updating the enfold calls, which @systemcatch is more familiar with.
Thanks for the feedback. We had a note to revisit enfold in the copy constructor since we would now be able to just copy the datetime object as is rather than having to enfold again. Do we want to ignore that and just leave it for a future PR?
Thanks for the feedback. We had a note to revisit enfold in the copy constructor since we would now be able to just copy the datetime object as is rather than having to enfold again. Do we want to ignore that and just leave it for a future PR?
Not sure what you mean by copy constructor?
Oh oops sorry I meant replace: https://github.com/arrow-py/arrow/blob/609b630b9f5a4b814377053965b93d78fd979c64/arrow/arrow.py#L777-L823
We probably don't need enfold here anymore since datetime would replace fold natively. Thoughts?
You're right, how about I make an issue to update the enfold calls after 1.0.0 is released?
Ref: https://github.com/arrow-py/arrow/issues/878
Want to approve so we can get this merged @systemcatch?
@isac322 You should be good to now implement type checking off of master!
Python 2.7 & 3.5 Deprecation Checklist
setup.py
classifiers andpython_requires
to declare arrow only supports Python 3.6+pyupgrade --py36-plus
datetime.timestamp()
MAX_TIMESTAMP
constant withdatetime.max.timestamp()
isinstance(value, numbers.Integral)
toisinstance(value, int)
isstr
function__cmp__()
method in arrow.pyenfold
calls in code @systemcatchBreaking changes for v1.0.0
arrow.py
(requires deprecation warning beforehand)General Changes for v1.0.0
setup.py
Closes: https://github.com/arrow-py/arrow/issues/465 Closes: https://github.com/arrow-py/arrow/issues/861 Closes: https://github.com/arrow-py/arrow/issues/739