arrow-py / arrow

🏹 Better dates & times for Python

https://arrow.readthedocs.io

Apache License 2.0

8.71k stars 673 forks source link

Fix linting CI and tweak is_between tests #905

Closed jadchaar closed 3 years ago

jadchaar commented 3 years ago

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

[ ] 🧪 Added tests for changed code.
[x] 🛠️ All tests pass when run locally (run tox or make test to find out!).
[x] 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
[ ] 📚 Updated documentation for changed code.
[x] ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Implement test mentioned by @eumiro in https://github.com/arrow-py/arrow/pull/903#discussion_r549204240 and fix flake8 pointless comparison errors.

codecov[bot] commented 3 years ago

Codecov Report

Merging #905 (f440d1d) into master (6825f8a) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #905   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines         1817      1817           
  Branches       318       318           
=========================================
  Hits          1817      1817

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6825f8a...f440d1d. Read the comment docs.

eumiro commented 3 years ago

Thank you for fixing that. Actually with all those automatic linters and formatters one should plan to update them (and their opinion on the real codebase) at some milestones, together with adding/dropping support for Python versions and connected modernizations of the code. Otherwise we'll get such random project-purpose-unrelated updates at any time. What do you think?

jadchaar commented 3 years ago

Thank you for fixing that. Actually with all those automatic linters and formatters one should plan to update them (and their opinion on the real codebase) at some milestones, together with adding/dropping support for Python versions and connected modernizations of the code. Otherwise we'll get such random project-purpose-unrelated updates at any time. What do you think?

The linting and code style tools are just for internal use, and we try to update them every few months. Version 1.0 is yet to be released, so that is one of the reasons we are making these big changes now.