arrow-py / arrow

🏹 Better dates & times for Python
https://arrow.readthedocs.io
Apache License 2.0
8.71k stars 673 forks source link

Fix German time frames #922

Closed weddige closed 3 years ago

weddige commented 3 years ago

The rules for German timeframes for only_distance=True where incomplete.

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

This PR fixes several missing cases in GermanBaseLocale.

codecov[bot] commented 3 years ago

Codecov Report

Merging #922 (1450592) into master (87cd4a9) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #922   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9        10    +1     
  Lines         1886      1896   +10     
  Branches       311       311           
=========================================
+ Hits          1886      1896   +10     
Impacted Files Coverage Δ
arrow/locales.py 100.00% <100.00%> (ø)
arrow/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 87cd4a9...625a923. Read the comment docs.

jadchaar commented 3 years ago

Thanks for the contribution @weddige, much appreciated!