arrow-py / arrow

🏹 Better dates & times for Python

https://arrow.readthedocs.io

Apache License 2.0

8.71k stars 673 forks source link

Bump version to 1.0.0 and update CHANGELOG #924

Closed systemcatch closed 3 years ago

systemcatch commented 3 years ago

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

[ ] 🧪 Added tests for changed code.
[ ] 🛠️ All tests pass when run locally (run tox or make test to find out!).
[ ] 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
[ ] 📚 Updated documentation for changed code.
[ ] ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Still a WIP

codecov[bot] commented 3 years ago

Codecov Report

Merging #924 (7a4c9cd) into master (f15a7ae) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #924   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         1896      1896           
  Branches       311       311           
=========================================
  Hits          1896      1896

Impacted Files	Coverage Δ
arrow/_version.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f15a7ae...ae67704. Read the comment docs.

systemcatch commented 3 years ago

Hey guys I will make the suggested changes then get this ready for review. Do you think we should just link to the migration guide for breaking changes or do they need to be in the changelog as well?

jadchaar commented 3 years ago

Hey guys I will make the suggested changes then get this ready for review. Do you think we should just link to the migration guide for breaking changes or do they need to be in the changelog as well?

I think just linking an being explicit about the migration guide outlining the breaking changes is sufficient.

krisfremen commented 3 years ago

Let's ship it! 💎 🚀 🚀 🚀 🚀

Feeling excited!

michael-k commented 3 years ago

There's no tag on GitHub and no release on PyPI. Is this on purpose? Just wondering :)

systemcatch commented 3 years ago

There's no tag on GitHub and no release on PyPI. Is this on purpose? Just wondering :)

Haha no, one of us needs to push the button to publish. Should be coming today when I finish work.

systemcatch commented 3 years ago

@michael-k and it's released! :partying_face: