arrowrbook / book

https://arrowrbook.com
9 stars 0 forks source link

Render to PDF and fix some issues #15

Closed nealrichardson closed 2 months ago

nealrichardson commented 2 months ago

This PR adds the style sheet and quarto config to render to PDF. Other changes:

Running list of other things we need to fix in the PDF, not comprehensive but just stuff I noticed:

Final question: by default, quarto render renders all formats, so both html and pdf. You can pick one locally by doing quarto render --to pdf. But in CI: do we want to only render HTML? Or, render both, and maybe put the PDF in a build artifact? We probably don't want what I imagine is the default, which renders both and then deploys both--I don't think we want the pdf version of the book on the website. In this PR, I switched it to just do HTML and made https://github.com/arrowrbook/book/issues/17 for us to sort out enabling it.

github-actions[bot] commented 2 months ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-08-25 18:35 UTC

jonkeane commented 2 months ago

CRS plots (section 8.3.1) have subtitles that overprint

I can handle this one

jonkeane commented 2 months ago

Another thing I noticed: at the end of the intro section for https://arrowrbook.com/datasets.html we have paths that are on my machine (and also quite long) could we post-process those to remove the personal path bits which would also make them shorter too?

nealrichardson commented 2 months ago
Screenshot 2024-08-25 at 2 03 38 PM

Hmm, the datasets png still doesn't look right.

nealrichardson commented 2 months ago

Made followup issues for the things I see left, merging this one.