search

arrowrbook / book

https://arrowrbook.com
8 stars 0 forks source link

Render PDF in CI #17

Closed nealrichardson closed 3 weeks ago

nealrichardson commented 3 weeks ago

https://github.com/arrowrbook/book/pull/15 adds config to build the PDF but disabled building it in CI until we can decide how we want to deal with it.

thisisnic commented 3 weeks ago

Do we need to enable this at all? We only need to do this for the version to send to the publisher which we've nearly got, and probably don't want somewhere folks can grab that version of the book from as a PDF anyway.

nealrichardson commented 3 weeks ago

Yeah maybe not? Not sure how much we're going to be iterating on the book while we're trying to make the PDF, and having it in CI would alert us if we accidentally broke something. Though the things we're more likely to "break" will be visual so won't show up as a failure to build the PDF.

thisisnic commented 3 weeks ago

I'm happy to just render the PDF locally instead of us spending time making this work, seems like we'd be removing it soon anyway,