search

arrowrbook / book

https://arrowrbook.com
8 stars 0 forks source link

Add extra content about bindings to advanced data manipulation chapter #27

Closed thisisnic closed 1 week ago

github-actions[bot] commented 3 weeks ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-09-06 15:35 UTC

thisisnic commented 3 weeks ago

I added in this Acero content to set things up for show_query() but I'm not sure I have explained it well enough, and think it nay constitute too deep a dive without actually adding anything for our readers. What dya think @nealrichardson ?

nealrichardson commented 2 weeks ago

I don't think it's too much. I'll review more closely this weekend and suggest some edits, but this feels appropriate to include in an advanced-topics chapter, IMO.

nealrichardson commented 2 weeks ago

I made some revisions in https://github.com/arrowrbook/book/pull/27/commits/57734c11052ff6b8cc9189c18565526d6c05e92c as it seemed easier than leaving a ton of comments.

thisisnic commented 2 weeks ago

From previous PR:

We could also add another example of a UDF that's more interesting than just "we don't have a binding for this function", like do a regression and have the UDF call predict() with that resulting model.