search

arrowrbook / book

https://arrowrbook.com
9 stars 0 forks source link

Expand on join examples #44

Closed thisisnic closed 1 month ago

thisisnic commented 2 months ago

I've added a bit of text to explain what's going on under the hppd (i.e. converting to an arrow table). IMO this is enough to satisfy my earlier concern that we weren't using an external reference table, as the principles are the same.

Closes #39

github-actions[bot] commented 2 months ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-09-14 19:12 UTC

nealrichardson commented 2 months ago

This doesn't solve all of #39 but feel free to separate out the other parts to a separate issue.

thisisnic commented 2 months ago

Cool, I think the only bit it misses is your comment as I wasn't sure exactly how to make that work, so I've opened https://github.com/arrowrbook/book/issues/46 and assigned it to you.

I think this pretty much covers everything else once I add in something pointing to the codebook join?

nealrichardson commented 1 month ago

I think I did everything here that I wanted with #46. The getting started example actually makes sense as a join, it's using one value as a baseline. The join example in data manipulation is contrived, so I called that out. I added more code below it showing that you can join on datasets or queries too, and I promoted a footnote in the geospatial section to the body of the chapter because it has a good practical use of joins.

thisisnic commented 1 month ago

Thanks for adding those updates @nealrichardson , I think this is ready to go!