arrowtype / shantell-sans

Shantell Sans, from Shantell Martin, is a marker-style font built for creative expression, typographic play, and animation.
https://shantellsans.com
SIL Open Font License 1.1
416 stars 6 forks source link

Fix style mapping names in static fonts #140

Closed arrowtype closed 6 months ago

arrowtype commented 6 months ago

The static fonts were previously failing this fontbakery check:

 >> com.adobe.fonts/check/family/max_4_fonts_per_family_name
    Verify that each group of fonts with the same nameID 1 has maximum of 4 fonts.

    Rationale:                                                                

    Per the OpenType spec:                                                                                                                                                            

    'The Font Family name [...] should be shared among at most four fonts that differ only in weight or style [...]'                                                                  

    More info: https://github.com/fonttools/fontbakery/pull/2372

    FAIL Family 'Shantell Sans Informal' has 12 fonts (should be 4 or fewer). [code: too-many]                                                                                        
    FAIL Family 'Shantell Sans Bouncy' has 12 fonts (should be 4 or fewer). [code: too-many]                                                                                          
    FAIL Family 'Shantell Sans Normal' has 12 fonts (should be 4 or fewer). [code: too-many]                                                                                          
    FAIL Family 'Shantell Sans Informal Bouncy' has 12 fonts (should be 4 or fewer). [code: too-many]

This PR fixes that by setting the stylemapfamilyname and stylemapstylename attributes more accurately in the designspace, then rebuilding the fonts. So, the check now passes:

▶ fontbakery check-adobefonts -c com.adobe.fonts/check/family/max_4_fonts_per_family_name "fonts/Shantell Sans/Desktop/Static/OTF/*.*tf"
Start ... running 1 individual check executions.

[P] 100%
Total:
    ERROR: 0
    FATAL: 0
    FAIL: 0
    WARN: 0
    INFO: 0
    SKIP: 0
    PASS: 1