Closed Hussainity closed 1 year ago
Hi @Hussainity
Ok, I see where the problem is and you got the point. But your solution is incomplete. You're missing a few things.
_get_data()
is used in _search_images()
as well:
self._search_images(*self._get_data())
_set_data()
is called in search()
so custom_image_name
should be set/avoided there:
if not self._search_again:
self._set_data(
search_params, path_to_dir, width, height, cache_discovery
)
Sorry, I see now you did all good. Merging this.
This patch fixes a bug where due to misaligned functions, the custom name parameter, a string, always became
False
(not evenNone
!) after the first page, even when a custom name was given._get_data()
's output does not match the input format ofsearch()
, and thus,search
readself._cache_discovery
's value ( a boolean, defaultFalse
) into it's localcustom_image_name
variable.