search

arrrlo / Google-Images-Search

[PYTHON] Search for image using Google Custom Search API and resize & crop afterwards
MIT License
176 stars 34 forks source link

non-standard dependency specifier click>=7.0<=8.1.*. #175

Closed mmccart3 closed 2 months ago

mmccart3 commented 6 months ago

The new version of pip (24.1) rejects the installation with the following message: DEPRECATION: google-images-search 1.4.6 has a non-standard dependency specifier click>=7.0<=8.1.*. pip 24.1 will enforce this behaviour change. A possible replacement is to upgrade to a newer version of google-images-search or contact the author to suggest that they release a version with a conforming dependency specifiers. Discussion can be found at https://github.com/pypa/pip/issues/12063

Would someone kindly update line 47 of setup.py

Paillat-dev commented 4 months ago

@mmccart3 Here you go https://github.com/Paillat-dev/Google-Images-Search just pip install git+https://github.com/Paillat-dev/Google-Images-Search

larsblumberg commented 2 months ago

@arrrlo would be great if you could make a new pypi release with the fix as it breaks all builds with recent pip versions.

Paillat-dev commented 2 months ago

@larsblumberg You can use my fork

larsblumberg commented 2 months ago

Thanks for the fix on your fork. As this is only a workaround (it requires git to be installed in the container), I'd be happy if @arrrlo could cherry-pick your fixing commit and release a new pypi package.

Paillat-dev commented 2 months ago

Right my bad. I will probably publish it to pypi too.

arrrlo commented 2 months ago

Hi all,

This is fixed. Pip doesn't break any more. New pypi version is live. Sorry for delayed response.

Paillat-dev commented 2 months ago

Thanks, no problem.