search

arsava / dokuwiki-template-vector

"vector" brings you the MediaWiki/Wikipedia 2010 look and feel for DokuWiki.
http://www.dokuwiki.org/template:vector
GNU General Public License v2.0
38 stars 9 forks source link

sitenotice css messed up Linkwizard #11

Open Klap-in opened 11 years ago

Klap-in commented 11 years ago

When the site notice is included, this is a included rendered page, with class .dokuwiki. https://github.com/syn-systems/dokuwiki-template-vector/blob/master/main.php#L565

The linkwizard adds itself to the first .dokuwiki in the page, thus using vector that's the sitenotice box. Now the div of the linkwiz are affected by the css of the sitenotice. https://github.com/splitbrain/dokuwiki/blob/master/lib/scripts/linkwiz.js#L47

Can you change something on the template to improve this case? or is it better that the Linkwizard will be improved?

andreashaerter commented 11 years ago

Hi,

it's correct that the link wizard adds itself to the first element with .dokuwiki class. This is expected and a bugreport by myself was due to the current behavior.

However, this should do no harm. I'll try to re-produce the problem. Which version of vector and DokuWiki are you using?

Klap-in commented 11 years ago

i'm still on Vector 2011-12-10 and DokuWiki Release 2012-01-25b "Angua". (i will update in near future)

The margins of the entries of the result div are changed, and the result div is not aligned symmetric.

linkwiz_vector_version2011-12-10

andreashaerter commented 11 years ago

Thanks for your report. I was able to reproduce the error (margins/padding are a bit messed up). There are some styles of the original vector for MediaWiki which are for #bodycontent. Therefore the rendering is different when the wizard is added to the sitenotice-div instead of the bodycontent-div.

I'll provide a patch ASAP.

Edit: thanks for the screenshot (you answered while I was typing my update) :-), same result here.

Klap-in commented 11 years ago

I meet another situation with the indexmenu plugin, where stuff is added to the first .dokuwiki div too, and the css of the notice field messed up things. Maybe the sitenotice block can be place inside the div.dokuwiki in stead of wrapping it Is it possible to include this before Weatherwax release?

Klap-in commented 11 years ago

I tried to create a proposal, but i takes me too much time to understand all that different css from different sources...and how to override that efficient.

Amazing how you manage to maintain this template!