arsava / dokuwiki-template-vector

"vector" brings you the MediaWiki/Wikipedia 2010 look and feel for DokuWiki.
http://www.dokuwiki.org/template:vector
GNU General Public License v2.0
38 stars 9 forks source link

lib/tpl/vector/user/screen.css ignored in Ponder Stibbons #27

Open theolmue opened 10 years ago

theolmue commented 10 years ago

I did some changes in layout by using lib/tpl/vector/user/screen.css in Binky. This worked well. Today I upgraded to Ponder Stibbons. After that the configurations in lib/tpl/vector/user/screen.css are ignored. I checked, that the file is in place and unchanged. Any idea, whats wrong?

My screen.css:

/* en: Place for user defined CSS rules (screen media) - this file can safely be preserved when updating. See README for details.

de: Ort für benutzerdefinierte CSS-Regeln (screen media) - Diese Datei kann beim Durchführen von Updates ohne Risiko beibehalten werden. Konsultieren Sie die README für Detailinformationen. */

/* Sidebar breiter machen (15em statt 10em) */
div#content,
#head-base,
div#footer,
div#panel,
#p-logo,
#p-logo a,
#left-navigation {
    margin-left: 15em !important;
}

I posted this issue already on GitHub Dokuwiki. They wrote, its an issue at vector template.

I also started a diskussion in german forum of dokuwiki. If you can read german, it may be helpfull.

andreashaerter commented 10 years ago

I'll investigate the over-all Ponder Stibbons compatibility on the WE, fixing issues etc. Sorry for the delay, the release was a bit of a surprise (there where no release candidates?!)

Klap-in commented 10 years ago

After bit trying: when i add mods to static/3rd/dokuwiki/_imgdetail.css or static/3rd/dokuwiki/_admin.css , these are displayed, when i add changes to static/3rd/vector/main-ltr.css , static/css/screen.css or user/screen.css these are not displayed.

[stylesheets]
; screen
; load the DokuWiki styles. See <http://j.mp/eq8zSo> why I am doing this.
static/3rd/dokuwiki/_imgdetail.css        = screen
static/3rd/dokuwiki/_media_popup.css      = screen
static/3rd/dokuwiki/_media_fullscreen.css = screen
static/3rd/dokuwiki/_fileuploader.css     = screen
static/3rd/dokuwiki/_tabs.css             = screen
static/3rd/dokuwiki/_links.css            = screen
static/3rd/dokuwiki/_toc.css              = screen
static/3rd/dokuwiki/_footnotes.css        = screen
static/3rd/dokuwiki/_search.css           = screen
static/3rd/dokuwiki/_recent.css           = screen
static/3rd/dokuwiki/_diff.css             = screen
static/3rd/dokuwiki/_edit.css             = screen
static/3rd/dokuwiki/_modal.css            = screen
static/3rd/dokuwiki/_forms.css            = screen
static/3rd/dokuwiki/_admin.css            = screen

; load the most important MediaWiki vector styles
static/3rd/vector/main-ltr.css = screen

; load the specific "vector for dokuwiki" styles
static/css/screen.css          = screen
user/screen.css                = screen

Remarkable: When looking at the downloaded files from the server, the css.php file contains all the content of the files marked with screen above. But its contents is not interpretted in the browser (Ubuntu Firefox&Chrome)

Can there be some bad chars somewhere?

Klap-in commented 10 years ago

Remark from forum was that uncommentting static/3rd/vector/main-ltr.css will let interpret static/css/screen.css and user/screen.css again. I can confirm this.

Klap-in commented 10 years ago

The faulty snippet is:

div#content a.external,
div#content a[href ^="gopher://"] {
    background: url(static/3rd/vector/external-link-ltr-icon.png) center right no-repeat;
    padding: 0 13px 0 0;
}
div#content a[href ^="https://"],
.link-https {
    background: url(static/3rd/vector/lock-icon.png) center right no-repeat;
    padding: 0 13px 0 0;
}
div#content a[href ^="mailto:"],
.link-mailto {
    background: url(static/3rd/vector/mail-icon.png) center right no-repeat;
    padding: 0 13px 0 0;
}
div#content a[href ^="news://"] {
    background: url(static/3rd/vector/news-icon.png) center right no-repeat;
    padding: 0 13px 0 0;
}
div#content a[href ^="ftp://"],
.link-ftp {
    background: url(static/3rd/vector/file-icon.png) center right no-repeat;
    padding: 0 13px 0 0;
}
div#content a[href ^="irc://"],
div#content a.extiw[href ^="irc://"],
.link-irc {
    background: url(static/3rd/vector/talk-icon.png) center right no-repeat;
    padding: 0 13px 0 0;
}

This is compressed to:

div#content a.external,div#content a[href ^="gopher:background:url(/wiki/lib/tpl/vector/static/3rd/vector/external-link-ltr-icon.png) center right no-repeat;padding:0 13px 0 0;}div#content a[href ^="https:.link-https{background:url(/wiki/lib/tpl/vector/static/3rd/vector/lock-icon.png) center right no-repeat;padding:0 13px 0 0;}div#content a[href ^="mailto:"],.link-mailto{background:url(/wiki/lib/tpl/vector/static/3rd/vector/mail-icon.png) center right no-repeat;padding:0 13px 0 0;}div#content a[href ^="news:background:url(/wiki/lib/tpl/vector/static/3rd/vector/news-icon.png) center right no-repeat;padding:0 13px 0 0;}div#content a[href ^="ftp:.link-ftp{background:url(/wiki/lib/tpl/vector/static/3rd/vector/file-icon.png) center right no-repeat;padding:0 13px 0 0;}div#content a[href ^="irc:div#content a.extiw[href ^="irc:.link-irc{background:url(/wiki/lib/tpl/vector/static/3rd/vector/talk-icon.png) center right no-repeat;padding:0 13px 0 0;}

The original css was valid css? In that case DokuWiki's compressor needs a fix. I reopened https://github.com/splitbrain/dokuwiki/issues/683

selfthinker commented 10 years ago

Yup, it's confirmed that it's a bug in the DokuWiki core (see bug report @theolmue added to the end of this report). Until the core issue is fixed, you can "fix" it by disabling compression [https://www.dokuwiki.org/config:compress]. Maybe best close this and only keep #26 open (as the rest are duplicates)?

bergonzzi commented 10 years ago

Confirming that disabling css and javascript compression fixes this and also formatting of tables which is broken in this release as well (no borders are displayed).

Klap-in commented 10 years ago

In the development version of dokuwiki the compressor is fixed, see: splitbrain/dokuwiki#683