search

arsava / dokuwiki-template-vector

"vector" brings you the MediaWiki/Wikipedia 2010 look and feel for DokuWiki.
http://www.dokuwiki.org/template:vector
GNU General Public License v2.0
40 stars 10 forks source link

QR Code link breaks https #8

Closed Alanceil closed 11 years ago

Alanceil commented 11 years ago

When displaying the new QR Code, the image is included from a http:// URL. This breaks pages delivered with https://, leading to a "this pages contains unsecure content" error.

Could you build in a check for https and if true, display the image this way ? I imagine the easiest way to do this would be for the PHP to fetch the image before displaying, because a simple replacement of

http://api.qrserver.com/v1/...

to

https://api.qrserver.com/v1/...

returns a certificate error - since qrserver.com does not use the correct certificate:

"You attempted to reach api.qrserver.com, but instead you actually reached a server identifying itself as *.ikt-werk.de."

andreashaerter commented 11 years ago

You're right. I will do the following within the next days:

andreashaerter commented 11 years ago

api.qrserver.com is now available via SSL. I'm going to patch vector and monobook to use HTTPS when one's DokuWiki is using SSL.

andreashaerter commented 11 years ago

Next release containing the fix will be done within the next days. Thanks for reporting this issue.

Alanceil commented 11 years ago

Wow, thanks for fixing it so fast.