search

arsava / dokuwiki-template-vector

"vector" brings you the MediaWiki/Wikipedia 2010 look and feel for DokuWiki.
http://www.dokuwiki.org/template:vector
GNU General Public License v2.0
40 stars 10 forks source link

Generate QR code on client side rather than externally #9

Open sinky opened 11 years ago

sinky commented 11 years ago

Rather than using external QR-Code generator (http://goqr.me) use a client side generator library https://github.com/lrsjng/jQuery.qrcode

DATENSCHUTZ ;-)

andreashaerter commented 11 years ago

Thanks for your input. However, I don't like two facts

  1. Introduce a new third party dependency
  2. It is a JS-only solution

In principle, you are right regarding the fact that requesting an external image with dynamic content leaks information to the external resource. But unlike the Google Charts API or other providers, api.qrserver.com / goQR.me does not log nor analyze the QR Code data, the query-string-part of the referrer etc.pp. This is the service's privacy policy and I personally guarantee for it (QR-Server is a service provided by my company).

But I can understand if you don't want to trust anyone, including me (as long as you can't verify what is going on, like you can look at the source code of vector before uploading it to your server). So I might implement your proposed JS-solution as an configurable alternative, some kind of "QR Code provider" setting. But I can't promise anything in the near future... (my spare time is very limited at the moment)

Alanceil commented 11 years ago

I'd be very happy if there'd be a client-side QR code variant in the future. I had to disable it after querying the person responsible for data protection laws in our organisation :-/