search

arsenaltech / nova-tab

Laravel Nova Tabs
74 stars 17 forks source link

Discussion translatey(2px) #5

Closed JapSeyz closed 5 years ago

JapSeyz commented 6 years ago

Hey, what's the thinking behind lowering the tabs down into the other tabs' content with translateY(2)?

shabbirbharmal commented 5 years ago

Not sure if I understand what you mean. Can you please elaborate?

XGhozt commented 5 years ago

I changed my tabs to look like this. Should I put in a merge request? I'm sorry @shabbirbharmal but the default tab design could be improved. I'm just glad we have tabs in Nova though, your package is great!

image

Edit: I also removed the animation almost completely because it just makes tabs "feel slow" to the end user. But you can easily do this yourself.

shabbirbharmal commented 5 years ago

Would appreciate a pull request if you have already made changes. Thank you!

XGhozt commented 5 years ago

I've submitted the pull request. I don't usually contribute much on github, so hopefully I've done it correctly.

shabbirbharmal commented 5 years ago

Looks great. Thanks!