arsenetar / dupeguru

Find duplicate files
https://dupeguru.voltaicideas.net
GNU General Public License v3.0
5.47k stars 418 forks source link

User unable to determine if dupeGuru is actually doing scan #700

Open JustinReinhart opened 4 years ago

JustinReinhart commented 4 years ago

Describe the bug I initiated a scan and dupeGuru instantly says it is "20%" completed and that 0 matches are found. There is no other indication in the dupeGuru UI that the app is doing any work at all. It stays here on 20%, unmoving, unchanging.

A few hours later it finished doing the job and instantly jumped from 20% to showing me the results window. The entire time I was wondering, "Is it actually doing the work?" and "How long is it going to take?"

Expected behavior Ideally, if you could just count the files and tell me you're on file 67 of 203,457 and keep updating the UI, that would be great. At least the user would have some idea there is work being completed and roughly how much time it may take - OR - display the amount of data read in gigabytes so the user can see something moving.

Desktop (please complete the following information):

Additional context I am not certain, but this may only be a problem when scanning a drive like a Western Digital Passport, which I am using. It is a "self-encrypting" drive and dupeGuru doesn't handle it quickly like it does for other drives. My guess is it is not able to use as many shortcuts for determining file hashes, etc. FYI, it does not use EFS encryption native to windows. It is hardware encryption. User has to enter a password to unlock the drive's partition.

Also I was performing a Folder match scan where the target was two single folders containing hundreds of large (1GB+) rar files. The combination of all of these details may have resulted in the UI not updating for a very long period of time—in my case, for the entire scan.

arsenetar commented 3 years ago

This should be at least partially addressed by 4c3dfe2f1f11566534d3eb8d2d54bdcc688211ab (during the collection phase) and 78fb052d77315205efbf369596a7c517e39d6182 (matches phase for folder/file matches). Image matching already has more output.

arsenetar commented 2 years ago

@JustinReinhart I recommend trying the new 4.2.0 version and see if that addressed your concerns here as it includes several changes improving output while scanning.

1024mb commented 2 years ago

I don't know if it has anything to do with the changes but when I'm scanning a directory for similar image files the app stays like this for a long time:

dupeguru-win64_2022-05-08_14-08-27

I'm guessing is reading the db? Idk but it shouldn't take so long as it's in a SSD drive, I don't see any CPU usage either. After cancelling and re-launching dupeGuru it's now scanning the files. This has happened a couple times before too (not before the update, before this example) and restarting the app helps.

arsenetar commented 2 years ago

@1024mb I have not see this issue, does the number of files reported (2730) in that screenshot match what you would expect for the total number of files in the scan you were running? Providing the debug log may be helpful in determining what is going on if you can reproduce this with the debug logging turned on.