arshadansari27 / fitranginew

1 stars 0 forks source link

ADVENTURE TRIPS – INNER PAGE #345

Closed YunusDange closed 9 years ago

YunusDange commented 9 years ago

1) QUICK INFO

2) QUICK INFO DATE – Content change (to understand this See New “Add a Trip” Form #342 )

3) QUICK INFO AMOUNT – Content change (to understand this See New “Add a Trip” Form #342 )

4) EVENT DISCUSSION Tab Should come last & Show Overview TAB First (People will not interact until they find something useful and in our present case giving details is the main offering)

5) Can we bring list of interested Users at the place shown in the image below? screenshot-2015-08-23-08 11 21

It will solve 3 things....

6) Not all TAB’s Data is available for all trips, sometime there will be an Empty TAB in some listings...so can we create a functionality where if Organiser doesn't enter any data in any TAB then that TAB should be Hidden Means User should not see a empty TAB (organizer will not have any control over this..so this thing will work) screenshot-2015-08-23-17 30 05

YunusDange commented 9 years ago

Remaining Things

1) QUICK INFO AMOUNT – Content change (to understand this See New “Add a Trip” Form #342 )

When Organizer doesn’t give any amount and tick “ Price On Request” option while uploading Trip then in the amount section the word “Price On Request” should come

2) EVENT DISCUSSION Tab goes last as per the instruction...but can we have arrangement like all those discussions come below the content of other Tab's and Separately in the last Tab (as event discussion tab anyway will not have any content as such)??

3) 6) Not all TAB’s Data is available for all trips, sometime there will be an Empty TAB in some listings...so can we create a functionality where if Organiser doesn't enter any data in any TAB then that TAB should be Hidden Means User should not see a empty TAB (organizer will not have any control over this..so this thing will work) b2ed6d96-49bc-11e5-8dc0-36f0d77b110f

arshadansari27 commented 9 years ago

1 and 3 are same right? 6 ) I made that change.. It was working on my end. Can u give me the link to test on live?

YunusDange commented 9 years ago

Yes 1and 3 are same issue

For 6) just try to delete content from any TAB from existing trip listing and see whether it gets hide.... From my end it is still visible and empty tab is there On 04-Sep-2015 10:27 PM, "Mohammed Arshad Ansari" notifications@github.com wrote:

1 and 3 are same right? 6 ) I made that change.. It was working on my end. Can u give me the link to test on live?

— Reply to this email directly or view it on GitHub https://github.com/arshadansari27/fitranginew/issues/345#issuecomment-137790369 .

arshadansari27 commented 9 years ago

Check the functionality.. if it is working on live!

YunusDange commented 9 years ago

Okkz..it's 3) is working now

Only thing remaining is

6) Not all TAB’s Data is available for all trips, sometime there will be an Empty TAB in some listings...so can we create a functionality where if Organiser doesn't enter any data in any TAB then that TAB should be Hidden Means User should not see a empty TAB (organizer will not have any control over this..so this thing will work)

just try to delete content from any TAB from existing trip listing and see whether it gets hide.... From my end it is still visible and empty tab is there

arshadansari27 commented 9 years ago

I think 6 is happening because there are spaces that fill the tab. So it looks empty but there are spaces which are not letting it hide. I'll test this theory when I return

On 11:29AM, Sat, Sep 5, 2015 Yunus Dange notifications@github.com wrote:

Okkz..it's working now

Only thing remaining is

6) Not all TAB’s Data is available for all trips, sometime there will be an Empty TAB in some listings...so can we create a functionality where if Organiser doesn't enter any data in any TAB then that TAB should be Hidden Means User should not see a empty TAB (organizer will not have any control over this..so this thing will work)

just try to delete content from any TAB from existing trip listing

and see whether it gets hide.... From my end it is still visible and empty tab is there

Reply to this email directly or view it on GitHub https://github.com/arshadansari27/fitranginew/issues/345#issuecomment-137913073 .

YunusDange commented 9 years ago

I don't see it is working .... or this is because i am just trying to delete content from tab, saving and then checking...Is it only working when we kept the TAB empty at the time of listing a trips..???

Don't know

arshadansari27 commented 9 years ago

Let's test this on call..

On 11:30AM, Mon, Sep 7, 2015 Yunus Dange notifications@github.com wrote:

Reopened #345 https://github.com/arshadansari27/fitranginew/issues/345.

— Reply to this email directly or view it on GitHub https://github.com/arshadansari27/fitranginew/issues/345#event-402455424 .

arshadansari27 commented 9 years ago

Gimme a link of any trip where this is happening...

YunusDange commented 9 years ago

All the trips....select any trip and delete content from any tab > save and check....nothing happens That Tab will be still visible

YunusDange commented 9 years ago

Not done.....! nothing happens .....Tab is still visible

arshadansari27 commented 9 years ago

Where are u deleting feom?

On 8:44AM, Tue, Sep 8, 2015 Yunus Dange notifications@github.com wrote:

Reopened #345 https://github.com/arshadansari27/fitranginew/issues/345.

— Reply to this email directly or view it on GitHub https://github.com/arshadansari27/fitranginew/issues/345#event-403174202 .

YunusDange commented 9 years ago

I think ..it's working in New Treks created...so i am closing this ...will create new ticket if found this not working.