arshadcodes / AgencyWebsite

Accepting the hacktoberfest contribution 2024
MIT License
14 stars 48 forks source link

Optimize and make better by correcting file names, making code more modular, etc #17

Open ShivRaiGithub opened 1 week ago

ShivRaiGithub commented 1 week ago

I would like to make few optimized changes like there are few files which do not follow a standard naming practice which may cause inconvenience, put the constants into a separate file for better modularity, making css classes instead of inline css, etc.

Please label this issue for Hacktoberfest and assign it to me. Thank you.

arshadcodes commented 1 week ago

Explain your issue well

ShivRaiGithub commented 1 week ago

image You see how some files have spaces in between their names, 2 main.jsx. Although it isn't causing any errors yet the file name formats seem random at first glance.

Some files contain constants defined in them like projects, steps, etc whereas it would be better to have a separate file of constants to better handle them, ensure consistency and remove redundancy, like here : Navbar and Footer both are creating same constants to be used image image

These inline css styles can be made into a css class : image

arshadcodes commented 1 week ago

Go for it and keep updating your repo untill you send PR Coz other devs are doing work on default naming

ShivRaiGithub commented 1 week ago

Will send it ASAP.

Adeesh-bode commented 8 hours ago

I can try , if it not assigned yet, you can see my repo's like boatXrsactstore and more project