search

arshadkazmi42 / android-contacts-scifiui

Contacts manager app, with a Scifi UI
GNU General Public License v3.0
4 stars 8 forks source link

Add runtime permissions #2

Closed arshadkazmi42 closed 6 years ago

arshadkazmi42 commented 6 years ago

App does not asks for contacts access permission and does not works until permission is given manually by going to app settings.

Need to add asking for runtime permission on app launch.

knightcube commented 6 years ago

May I work on this issue? I am thinking of adding Dexter permissions library.

arshadkazmi42 commented 6 years ago

@knightcube yes please. go ahead and create a PR. Dexter library looks good.

djcass44 commented 6 years ago

Hey, I opened a pull request to fix this: #16 It uses only native android code, no libraries involved!

sankalpchauhan-me commented 6 years ago

I have opened a PR for this #18

arshadkazmi42 commented 6 years ago

@sankalpchauhan-me @djcass44 has already created a pr for this. you might wanna look at some other issues.

sankalpchauhan-me commented 6 years ago

No problem @arshadkazmi42, will continue to contribute to this project for any new issues.

@sankalpchauhan-me @djcass44 has already created a pr for this. you might wanna look at some other issues.

prateekvijayvergiya commented 6 years ago

If this issue is fixed then kindly close this.

arshadkazmi42 commented 6 years ago

@prateekvijayvergiya Thanks for reminding. I completely forgot about this.