arshadkazmi42 / simple-date-validator

Simple Date Validator Library (NodeJs)
GNU General Public License v3.0
3 stars 12 forks source link

Add Code Quality Badge #24

Closed arshadkazmi42 closed 6 years ago

arshadkazmi42 commented 6 years ago

Describe the bug Add Code Quality Badge to README

Additional context

Add Code Quality badge next to downloads badge in README file

just copy the below code and add it in readme below downloads code

[![Codacy Badge](https://api.codacy.com/project/badge/Grade/12b4f952ec1e497e8d2c2f88638672f5)](https://www.codacy.com/app/arshadkazmi42/simple-date-validator?utm_source=github.com&utm_medium=referral&utm_content=arshadkazmi42/simple-date-validator&utm_campaign=Badge_Grade)

To work on this

  1. Put a comment here who ever is working on it.
  2. Also tag this issue in your Pull Request description. Anyone who is not following above two steps, their PR will be rejected
NefixEstrada commented 6 years ago

I'm doing this

NefixEstrada commented 6 years ago

Nvm, just saw the first-timers-only badge

arshadkazmi42 commented 6 years ago

@NefixEstrada Cool. goAhead and create a PR. Do read the notes at the bottom of the issue

arshadkazmi42 commented 6 years ago

@NefixEstrada Opening it for first timers of the Repo, if its your first PR for this repo, then go ahead and work on this.

roebuk commented 6 years ago

Hi,

I'll happily take this 👍

arshadkazmi42 commented 6 years ago

@roebuk @NefixEstrada has shown interest first on this, we will wait for them to reply for sometime, if they do not come back, then you can work on it. Keep a track on this issue, you are second in the queue :)

roebuk commented 6 years ago

@arshadkazmi42 sounds good to me 👍

jcat1504 commented 6 years ago

Hi, I'll do this :)

arshadkazmi42 commented 6 years ago

@jcat1504 @roebuk approached here first. So I will give first priority to @roebuk PR, @roebuk If you are interested you can work on it, otherwise @jcat1504 has already opened a PR if you are fine with it, I will go ahead with her PR

roebuk commented 6 years ago

Hey I've attached my PR over here

https://github.com/arshadkazmi42/simple-date-validator/pull/26

NefixEstrada commented 6 years ago

Go ahead and merge it, it's not an issue for me :D

arshadkazmi42 commented 6 years ago

Go ahead and merge it, it's not an issue for me :D

Thanks @NefixEstrada

arshadkazmi42 commented 6 years ago

Hey I've attached my PR over here

26

@roebuk I have added a small comment in PR. Can you make that change