arshaw / xdate

A Modern JavaScript Date Library
http://arshaw.com/xdate/
GNU General Public License v2.0
681 stars 81 forks source link

Start months at 1, not zero #29

Closed benknight closed 9 years ago

benknight commented 9 years ago

I always forget that that the months are number 0-11 instead of 1-12. It's totally unnatural to write April 1st, 2015 as 2015, 3, 1. Also, shouldn't days also be zero-index if months are too? IMO the parameters should match how humans write dates.

benknight commented 9 years ago

Never mind, I'm realizing that this matches Date's implementation, and the point of this library is to wrap Date. D'oh! Closing.

arshaw commented 9 years ago

xdate just mimicked how the native javascript date object does it

arshaw commented 9 years ago

got it