arshubham / cipher

A simple application for encoding and decoding text
GNU General Public License v3.0
18 stars 10 forks source link

Added Translation Capabilities #22

Closed sahilarora3117 closed 5 years ago

sahilarora3117 commented 5 years ago

So translation work was done. Source: https://elementary.io/docs/code/getting-started#Adding-Translations

Tested compiles and works in Solus. Please test in Juno. Just someone has to add pot files to check if the translation works. Please add two dependencies (both for translations) appstream-glib-devel gettext

Also add valac as required dependency.

peteruithoven commented 5 years ago

The error:

Cannot copy '../nopt/bin/nopt.js' to a subdirectory of itself, '../nopt/bin/nopt.js'.
Error: Cannot copy '../nopt/bin/nopt.js' to a subdirectory of itself, '../nopt/bin/nopt.js'.
    at fs.readlink (/home/travis/build/arshubham/cipher/node_modules/fs-extra/lib/copy/copy.js:190:21)
    at FSReqWrap.oncomplete (fs.js:141:20)

I think you need to update your Travis.yml: https://github.com/elementary/houston/wiki/Continuous-Integration

ryonakano commented 5 years ago

Fixes #21