arshubham / cipher

A simple application for encoding and decoding text
GNU General Public License v3.0
18 stars 10 forks source link

Improve meson build and fixes #49

Closed NathanBnm closed 5 years ago

NathanBnm commented 5 years ago

This PR improves the way your app is build with meson with a better integration. I made a few fixes too. Let me know if you have any questions before merging.

Changelog

I'll have to make a few translation fixes in another PR once you'll have merged this one so please wait for translation updates before publishing a new release then :smile:

This PR is ready for review

arshubham commented 5 years ago

I would also like to keeps all language codes in po/LINGUAS . I am thinking of setting up a weblate instance for all my projects.

NathanBnm commented 5 years ago

@arshubham I made the changes.

arshubham commented 5 years ago

@NathanBnm Is there a way to test translations without changing system language?

NathanBnm commented 5 years ago

@arshubham no but I already tested with French translation and this is working fine. I'll just have to update some of them in another PR after this one.

NathanBnm commented 5 years ago

@arshubham resolved now

arshubham commented 5 years ago

Great, just added gettext action will update appdata and check if it is working.

arshubham commented 5 years ago

@NathanBnm You can update the translations now. Once the CI run is done.