search

arsilva87 / biotools

biotools: Tools for Biometry and Applied Statistics in Agricultural Science (R package)
https://arsilva87.github.io/biotools/
GNU General Public License v3.0
2 stars 0 forks source link

Package has too many dependencies #1

Open karthik opened 5 years ago

karthik commented 5 years ago

I am the editor on your JOSS submission. Your package has too many packages listed under Depends. This is bad practice and you should only use Imports where possible (and import specific functions you need). All the other optional bits need to be moved to Suggests.

Right now I cannot install your package, nor can the reviewer I assigned. It's because rpanel cannot be installed without specific tcltk widgets. This is not supported on Osx and therefore cannot be a hard dependency. This may work on Windows (which I'm assuming you're on). What is the purpose of rpanel here? What functions are you importing?

refactoring your package will make it possible for others to install it, particularly from GitHub since we are not reviewing what is on CRAN.

karthik commented 5 years ago

Still waiting on a response to this issue, @arsilva87 cc/ openjournals/joss-reviews#1321

arsilva87 commented 5 years ago

@karthik The package does not have those dependencies anymore.