search

arsilva87 / biotools

biotools: Tools for Biometry and Applied Statistics in Agricultural Science (R package)
https://arsilva87.github.io/biotools/
GNU General Public License v3.0
2 stars 0 forks source link

Please improve automated tests #4

Open diyadas opened 5 years ago

diyadas commented 5 years ago

As per openjournals/joss-reviews#1321

Code coverage is at 10% overall, though much higher for distclust.R.

Here's the beginning of the output of covr::report(): image

(Coverage for all others is 0%)

Please improve coverage (to at least 80%, I think @karthik suggested), or let us know why this isn't possible.

arsilva87 commented 5 years ago

@diyadas As I said before, the paper is focused on the main functions of biotools, which are related to optimization cluster analysis. Thus, the coverage of 10% does not represent a problem, for the main functions are tested. Nonetheless, biotools contains several other miscelaneous functions of minor interest to clustering analysis, but that could be helpful for the target audience. That is why the covarege test is low.

karthik commented 5 years ago

@arsilva87 Unfortunately your test coverage is extremely poor making it hard to trust your software's functionality. The one and only test you have is:

  to <- tocher(dist(rnorm(10)))
  expect_output(str(to), "List of 7")

We are publishing a paper on this software package and the test cannot simply cover one function. If your goal is to publish just that function, then it would be too trivial for publication in JOSS.

karthik commented 5 years ago

cc/ openjournals/joss-reviews#1321

arsilva87 commented 5 years ago

@karthik Please test coverage again. It has been improved. In fact, you can see that for a thorough analysis, biotools applies around 8 functions.

karthik commented 5 years ago

The tests are still too trivial and also fail for me.

On Tue, Jun 25, 2019 at 12:59 PM arsilva87 notifications@github.com wrote:

@karthik https://github.com/karthik Please test coverage again. It has been improved. In fact, you can see that for a thorough analysis, biotools applies around 8 functions.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/arsilva87/biotools/issues/4?email_source=notifications&email_token=AABBZ7Q2BSK6HUNO3J6YJE3P4J2IXA5CNFSM4HNQ2GMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYRNMAQ#issuecomment-505599490, or mute the thread https://github.com/notifications/unsubscribe-auth/AABBZ7VLMUU5TKZU3ZVER63P4J2IXANCNFSM4HNQ2GMA .