search

arskinner / Appcelerator-CardIO

Appcelerator wrapper for the Card.io credit card scanning library. Use the phone's camera to read credit card numbers and expiration dates.
Other
44 stars 25 forks source link

New property for CVV setting ignored on iOS #18

Closed bar-none closed 7 years ago

bar-none commented 7 years ago

Version 2.0.2 among other things moved the CVV option to a property. But line 118 in the ComLikelysoftCardioModule.m class module found here references field cardIOLogo when it should set field collectCVV instead. The net effect is collectCVV always keeps its initial setting, which is true.

arskinner commented 7 years ago

Good catch... just pushed the change and I'll post a new version

bar-none commented 7 years ago

Wow, that was FAST!

bar-none commented 7 years ago

Version 2.0.3 now correctly does not ask for the CVV when I use cardio.setCollectCVV(false); but the 'complete' event is not firing. When I tap Done, the app crashes/exits to the iOS home screen. When I use true it works, but requires the CVV entry. I'm guessing perhaps it is not safe to reference info.cvv on lines 182 and 190 of that same class module, when collectCVV is false.

arskinner commented 7 years ago

Possibly, let me test

arskinner commented 7 years ago

This should be fixed in 2.0.4

bar-none commented 7 years ago

Confirmed it is fixed, at least for iOS. Incidentally, your v2 also solves at two of the issues still listed as open.

arskinner commented 7 years ago

Thanks... looks like all the issues are resolved actually. For now!