arsv / perl-cross

configure and cross-compile perl
Other
81 stars 29 forks source link

bad generation of ppport.h #131

Closed fperrad closed 2 years ago

fperrad commented 2 years ago

with perl5.35.10 + perl-cross 1.3.7 (reusing patches for perl5.35.9), everything is OK.

$ ls -l ./perl-5.35.10/dist/Devel-PPPort/[Pp][Pp]*
-rw-r--r-- 1 user user      0 mai   25 15:41 ./perl-5.35.10/dist/Devel-PPPort/PPPort.bs
-rw-r--r-- 1 user user 559260 mai   25 15:41 ./perl-5.35.10/dist/Devel-PPPort/ppport.h
-rw-r--r-- 1 user user    735 mars   9  2020 ./perl-5.35.10/dist/Devel-PPPort/ppport_h.PL
-rw-r--r-- 1 user user 632237 mai   25 15:41 ./perl-5.35.10/dist/Devel-PPPort/PPPort.pm
-rw-r--r-- 1 user user  26112 mars  19 17:41 ./perl-5.35.10/dist/Devel-PPPort/PPPort_pm.PL
-rw-r--r-- 1 user user    196 mars   9  2020 ./perl-5.35.10/dist/Devel-PPPort/PPPort.xs

but with perl5.35.11 and perl5.36.0-RC, ppport.h is badly generated, in fact ppport.h contains a copy PPPort.pm

$ ls -l ./perl-5.36.0/dist/Devel-PPPort/[Pp][Pp]*
-rw-r--r-- 1 user user      0 mai   25 15:59 ./perl-5.36.0/dist/Devel-PPPort/PPPort.bs
-rw-r--r-- 1 user user 632237 mai   25 15:59 ./perl-5.36.0/dist/Devel-PPPort/ppport.h
-rw-r--r-- 1 user user    735 févr. 18  2019 ./perl-5.36.0/dist/Devel-PPPort/ppport_h.PL
-rw-r--r-- 1 user user 632237 mai   25 15:59 ./perl-5.36.0/dist/Devel-PPPort/PPPort.pm
-rw-r--r-- 1 user user  26112 mars  28 21:15 ./perl-5.36.0/dist/Devel-PPPort/PPPort_pm.PL
-rw-r--r-- 1 user user    196 déc.  28  2020 ./perl-5.36.0/dist/Devel-PPPort/PPPort.xs

when ppport.h is really included, the C compilation fails.

I found related warnings in stderr:

Makefile:314: warning: overriding recipe for target 'dist/Devel-PPPort/ppport.h'
Makefile:291: warning: ignoring old recipe for target 'dist/Devel-PPPort/ppport.h'
arsv commented 2 years ago

Fixed already, https://github.com/arsv/perl-cross/commit/14cf0abdb3136b5f54c3da65aa8f494679010d5d

fperrad commented 2 years ago

thanks