search

art-daq / artdaq

Other
0 stars 3 forks source link

Remove the "board_id" parameter, since its confusing when there's #201

Closed eflumerf closed 1 year ago

eflumerf commented 1 year ago

already a "fragment_id" parameter. Use the lowest Fragment ID configured for the metric reporting name.

eflumerf commented 1 year ago

This change should probably be discussed with the experiments to make sure they're not relying on board_id for anything, especially since it does feed into the names used for metrics.

ron003 commented 1 year ago

Maybe it's not that big of a deal -- several digitizer boards in one crate can all have the same frag_id's. I know they could have different frag_id's. Can we or should we somehow deprecate board_id?

eflumerf commented 1 year ago

No, fragment_id should be unique for each Fragment, and a single BoardReader can have multiple. AFAIK, the board_id is only being used in our code as the identifier for metrics, e.g. BoardReader.0