art-daq / artdaq

Other
0 stars 3 forks source link

one generator, multiple fragments #212

Closed pavel1murat closed 1 year ago

pavel1murat commented 1 year ago

in case a generator is creating more than one fragment, the artdaq commandable generator requires a list of fragment IDs and its length to be provided separately, as two independent input parameters.

https://github.com/art-daq/artdaq/blob/develop/artdaq/Generators/CommandableFragmentGenerator.cc#L63-L87

The length of the list is then required to be the same as the length input independently. At best, that check does seem to be doing anything, however if the two are different, the code throws an exception.

  1. What is the purpose of doing that ?
  2. Perhaps the requirement of the list length to be input independently from the list itself could be removed?