art-daq / artdaq_daqinterface

Other
0 stars 1 forks source link

sbndaq package versions are not posted to the run_history metadata.txt #149

Closed gennadiy-fnal closed 6 months ago

gennadiy-fnal commented 7 months ago

sbndaq package versions are not posted to the run_history metadata.txt.

Newer versions of Python are more strict if assignment to a tuple structure has more than the number of assigned elements. In this case, the (package, version) tuple is assigned to a list containing more than 2 entries, which I've resolved by trimming the list to the first two elements.

--- /nvme_scratch/products/artdaq_daqinterface/v3_12_07/rc/control/daqinterface.py  2023-11-08 15:07:26.000000000 -0600
+++ /nvme_scratch/products1/artdaq_daqinterface/v3_12_07/rc/control/daqinterface.py 2024-02-14 00:29:11.936525353 -0600
@@ -2108,7 +2108,7 @@

             for line in stdoutlines:
                 if re.search(r"^(%s)\s+" % ("|".join(needed_packages)), line):
-                    (package, version) = line.split()
+                    (package, version) = line.split()[:2]

                     if not re.search(r"v[0-9]+_[0-9]+_[0-9]+.*", version):
                         raise Exception(

A minor code change was posted to the bugfix/149_package_versions_in_metadata branch