search

art-daq / artdaq_daqinterface

Other
0 stars 1 forks source link

boot.fcl not correctly formed when user adds a variable which is a list #30

Closed eflumerf closed 2 years ago

eflumerf commented 2 years ago

This issue has been migrated from https://cdcvs.fnal.gov/redmine/issues/23224 (FNAL account required) Originally created by @jcfreeman2 on 2019-09-04 17:14:25

During DAQInterface regression testing, I noticed that in some runs on the ProtoDUNE cluster, the "boot.fcl" file didn't appear in the FHiCL-ized run record which gets saved in the database. Recreating the problem while running DAQInterface at a higher verbosity level, I see the following:

Caught fhicl::exception message=Caught fhicl::exception message=---- Parse error BEGIN
  detected at or near line 28, character 35, of file "-"

  trigcand600_tpwindow_inputs_keys: "["felix601","felix602","felix603","felix604","felix605","felix606","
felix607","felix608","felix609","felix610"]"
                                    ^
---- Parse error END

This, starting on line 1828 of np04-srv-024:/log/daqinterface_np04daq/DAQInterface_partition9.log . What appears to be going on is this: the guys working on dune-artdaq's self-trigger logic (Phil Rodrigues et al.) figured out that they could use a feature where DAQInterface allows you to override arbitrary FHiCL parameter values during bookkeeping if you define their override values in the boot file not just for scalar values, as had been done up to that point, but for lists as well. However, DAQInterface's fhiclize_boot_file.awk script doesn't know how to properly handle this scenario. This should be fixed.

This problem appears in, e.g., run 9587.

eflumerf commented 2 years ago

Comment by @jcfreeman2 on 2019-09-05 18:36:06

Now resolved with commit 7fbabacb1495e3312d84165e44762f2c1357e731 at the head of feature/issue23224_fix_boot_dot_fcl. The thing to look for is boot.fcl (as well as DataflowConfiguration.fcl) getting saved, where they weren't getting saved before.

eflumerf commented 2 years ago

Comment by @gennadiy-fnal on 2019-09-05 21:02:51

Works as expected.