search

art-daq / artdaq_daqinterface

Other
0 stars 1 forks source link

If just_do_it.sh can't perform a transition, DAQInterface hangs #58

Closed eflumerf closed 2 years ago

eflumerf commented 2 years ago

This issue has been migrated from https://cdcvs.fnal.gov/redmine/issues/21804 (FNAL account required) Originally created by @jcfreeman2 on 2019-01-30 17:35:43

Specifically, what I'm finding is that in the scenario that during the configuration transition DAQInterface expects a FHiCL document but can't find it among the subconfigurations it's been given, DAQInterface will (as expected), announce the problem and set itself back into the Booted state. just_do_it.sh will then, as expected, print

DAQ failed to enter ready state; exiting /home/jcfree/artdaq-utilities-daqinterface/bin/just_do_it.sh

...however, even though DAQInterface was launched prior to the execution of just_do_it.sh (i.e., just_do_it.sh doesn't "own" DAQInterface, it requires DAQInterface to already be up), DAQInterface will no longer respond to XML-RPC calls. It would be nice if, should something go wrong with a transition in just_do_it.sh, even if just_do_it.sh exits out DAQinterface should still function properly.

eflumerf commented 2 years ago

Comment by @jcfreeman2 on 2019-02-11 21:13:19

On further investigation, the hang was occurring whenever anything was typed into the shell DAQInterface was running in. Ron suggested I have DAQInterface ignore stdin by adding "<&-" to the DAQInterface alias. Change has been added to feature/issue21804_daqinterface_hang.

eflumerf commented 2 years ago

Comment by @jcfreeman2 on 2019-02-12 04:17:22

I've tested DAQInterface on feature/issue21804_daqinterface_hang; typing input into the same shell that DAQInterface is running in now appears to have no effect.

eflumerf commented 2 years ago

Comment by @eflumerf on 2019-02-12 22:13:08

Reviewed code and made sure that things work properly with the new code.

eflumerf commented 2 years ago

Comment by @jcfreeman2 on 2019-02-14 19:06:37

Using the fix Ron suggested appears to have solved the problem, as tested by myself and by Eric. Merged feature/issue21804_daqinterface_hang into develop and deleted the branch (feature/issue21804_daqinterface_hang, not develop).

eflumerf commented 2 years ago

Comment by @jcfreeman2 on 2019-02-19 20:46:31

I'm un-closing this Issue since the protocol is to close an Issue when there's an official release. Having said that, I consider this Issue to be "Reviewed" (not "Resolved" as marked) but for whatever reason that option's not appearing in my drop-down list.