art-from-the-machine / Mantella

Mantella is a Skyrim and Fallout 4 mod which allows you to naturally speak to NPCs using Whisper (speech-to-text), LLMs (text generation), and xVASynth / XTTS (text-to-speech).
https://art-from-the-machine.github.io/Mantella/
GNU General Public License v3.0
164 stars 41 forks source link

(Feature Request) Configurable "Assist" Keyword Blacklist #245

Open maeeeeee opened 4 months ago

maeeeeee commented 4 months ago

https://github.com/art-from-the-machine/Mantella/blob/1a8b30e6e64585c95b95b8a5037ffae65c77a9c9/src/output_manager.py#L549-L552

I'm unsure why this is coded in, but the end result on Claude 3 Opus is that a lot of lines are unnecessarily cut just because they mention the word "assist" -- for instance, "Welcome to the Riverwood Trader, how may I assist you?" An option to disable this in the config would be much appreciated.

art-from-the-machine commented 4 months ago

This can likely be moved to the "stop" setting (stop = #, assist) in the config.ini so that players can easily remove it. This "assist" keyword removal was added before the "stop" setting existed. Once moved, there might need to be a check to see if "assist" is in the first sentence, and if it is, let it generate. Otherwise LLMs will cut off before they get to say their first line.

But just to warn you @maeeeeee, LLMs use the word "assist" relentlessly!

DaymareOn commented 2 months ago

As "assist" is a word relentlessly used by llms (groans), this might be considered a bug and not a feature.