art-institute-of-chicago / aic-bash

A bash script to query our API for public domain artworks and render them as ASCII art
GNU Affero General Public License v3.0
153 stars 16 forks source link

Fix issue with git clone and repo permissions #1

Closed nllz closed 4 years ago

IllyaMoskvin commented 4 years ago

Thanks for the PR. On the one hand, what's there already is not wrong. It simply does the clone via SSH instead of HTTPS. See here for more info:

https://help.github.com/en/github/using-git/which-remote-url-should-i-use#cloning-with-ssh-urls

On the other hand, there is a higher barrier to entry for setting up your development environment to be able to clone stuff via SSH that via HTTPS. People who know how to clone stuff via SSH probably know how to translate HTTPS URLs to SSH ones when needed. For the majority of users, I'd agree that HTTPS is enough for read-only access.

So, yes, I'll accept this PR. Thanks!