art-programmer / MASC

MIT License
58 stars 6 forks source link

Incorrect inference commands in Readme.md #6

Closed mhalber closed 5 years ago

mhalber commented 5 years ago

Hi, it seems there is a typo with inference commands in the Readme.md, specifically, the split command is missing double hyphen:

python inference.py --dataFolder=[SCANNET_PATH] --task=predict_cluster_write split=test

I believe correct command should be:

python inference.py --dataFolder=[SCANNET_PATH] --task=predict_cluster_write --split=test
mhalber commented 5 years ago

I believe there is another issue with the Readme.md. Can we confirm that command to train confidence model should be:

python train_confidence.py --restore=0 --dataFolder=[SCANNET_PATH]

rather than stated

python train.py --restore=0 --dataFolder=[SCANNET_PATH]
art-programmer commented 5 years ago

Thanks for the corrections!