search

art103 / ar-t6

Re-write of er9x for the FS-T6 2.4GHz TX
GNU General Public License v2.0
19 stars 11 forks source link

Mod_Page_Mixer #6

Open Voxyn opened 9 years ago

Voxyn commented 9 years ago

Hi,

I tried the mixer menu and there are some error concerning the navigation flow. In my repository I have implemented an additional step for the submenues to work. Shall I push them to the repo?

michkrom commented 9 years ago

Cool! Need more hands!

Before checking in could you please make sure you have the latest. I have been frantically fixing misc problems last few days there and afaik it works now. All in main. Better yet clone main and verify before merging w your changes so your version stays clean.

Btw, I Have just come back from Maiden flight with art6. It worked fine but I had to adjust mixers. Mixer menues seemed to work fine. Exp for input channel assignments ...had to swap ail with elect...

Curves would be something fun to work on?

All timer features as well.

Michal

On Feb 18, 2015 1:58 PM, "Voxyn" notifications@github.com wrote:

Hi,

I tried the mixer menu and there are some error concerning the navigation flow. In my repository I have implemented an additional step for the submenues to work. Shall I push them to the repo?

— Reply to this email directly or view it on GitHub.

Voxyn commented 9 years ago

I have implemented and commited the first fix for the mixer menu. Can you push it to the repo?

Voxyn commented 9 years ago

And the first version of the curves edit menu is committed

michkrom commented 9 years ago

Cool. I did a expo/dr yesterday but I am out today. Id u r on a branch then pull from main integrate and give us a pull request. If u r on main then u have all control. Can't wait to see it. Btw what gcc version r u building with. Mine is 4.9.3. Michal On Mar 1, 2015 8:08 AM, "Voxyn" notifications@github.com wrote:

And the first version of the curves edit menu is committed

— Reply to this email directly or view it on GitHub https://github.com/art103/ar-t6/issues/6#issuecomment-76604507.

Voxyn commented 9 years ago

I get a git-receive-pack not permitted. Do I need any additional to push to upstream? Working with your master branch. My fork has not been updated since January

Voxyn commented 9 years ago

Ok, I pushed everything to https://github.com/Voxyn/art6test Have a look there and please add me to the collaborateurs of this repo. Thanks

michkrom commented 9 years ago

Voxyn. I think only original owner (art103) can add you as contributor. I do not seem to have the right "stuff" to do so or I do not know how. For time being you can generate "push" requests and I can merge them upstream to main. It would be best if you always make sure to pull/integrate latest main to your branch before creating "push" request. The code is in high flux at the moment :-). I looked at your changes and this is a good start - btw look at my latest checking with expo/dr (the curves menus should be similar edit-wise).

art103 commented 9 years ago

Hi Voxyn, I've added you - I had assumed that contributors could add other contributors, but I guess that isn't the case :) It's great to see the progress being made!

art103 commented 9 years ago

Sorry, note to self: "Close Issue" doesn't mean close the reply dialogue...

Voxyn commented 9 years ago

I have successfully pushed my changes to the repo. Curve mix editor is a playground at the moment. Will continue coding this evening.

michkrom commented 9 years ago

Yo! The fix to menu/submenu nav broke edit and colum modes. I have generalized the sub menu and in the process also popups. It works great now albeit there is a limitation : the sub menu cannot be a "form" (ie a scatter of filds rater then a scrollable "list" as used in expo/dr). Curves do not mark thei fields so the nav is blind there :-( for now... need to check it.