Game slice widget type - Githubissues

artasparks / glift

Go Lightweight Frontend

MIT License

115 stars 33 forks source link

Game slice widget type #136

Closed pconerly closed 8 years ago

pconerly commented 8 years ago

Hi again! @Kashomon

So, I'm gonna be blogging my game reviews, and I want a way to say: "write the move numbers from move X to move Y." I'm trying to make diagrams like in here: http://gobase.org/studying/articles/matthews/fuseki/08/

I know that we have an existing way to do this by adding the labels, but it becomes a not-fun manual process.

So here's my change. Here's what GameSliceTester.html looks like:

screen shot 2015-11-11 at 9 18 22 pm

pconerly commented 8 years ago

I'm currently using this and there are some bugs with trying to use the nextMovesPath anyway. I do want a way to pick a variation to go down, but it's broken currently...

//edit: I think I just misunderstood the indexing of the treepath, I got variations to work.

artasparks commented 8 years ago

Couple high level comments: Thanks, I think this does probably make sense to make its own widget, at least for now. There's a good chance that something like GPub would be the long term solution, but it's not worth considering at the moment.

I'm not sure I GameSlice is the best naming, but I'm having a hard time coming up with better naming.
Could you write some tests?

pconerly commented 8 years ago

As far as names go, how about Sequence or GameFigure? They're not much better but they might convey the idea.

What is GPub? Is that the markdown/sgf book format you mentioned in https://github.com/Kashomon/glift/issues/97 ?

artasparks commented 8 years ago

Ok, I'm going to merge this change in. Know that I see this game type as experimental. It's possible that I'll decide to combine this with the Example widget or rework this.