artasparks / glift

Go Lightweight Frontend
MIT License
115 stars 33 forks source link

Problems with hover styling #164

Closed artasparks closed 7 years ago

artasparks commented 7 years ago

From an email I got from Marcel:

I think the problem is in the attached glift_combined.js line 12755; marksTheme is undefined when stoneColor is BLACK_HOVER or WHITE_HOVER. Because after Black's answer, 1-1 would be a ko point, addMark wants to put a ko marker there in line 13275. It calls marksTheme.stroke, which crashes because marksTheme is undefined.

Yes, the BLACK_HOVER/WHITE_HOVER themes have been somewhat problematic. I'll write up a fix.