search

artasparks / glift

Go Lightweight Frontend
MIT License
115 stars 33 forks source link

Slight problem in tests glift.util not defined. #166

Open rdeveno opened 7 years ago

rdeveno commented 7 years ago

When building and running the tests I had several errors because glift.util wasn't defined. This seemed to happen in both phantomjs and firefox. It was a result of the util.js script include in QUnitTest.html appearing after all of the other utility scripts ... I changed the name of util.js to be aautil.js, forcing it to the start of the includes and all was well. No need to fix the issue but I thought I would mention it here in case anyone else has the same problem.

artasparks commented 7 years ago

Weird. How are you running your tests? Are you seeing this problem with gulp build-test. Or are you seeing it when you open glift/test/htmltests_gen/QunitTest.html directly?

I'm not able to repro this at the moment, so I'm curious.

rdeveno commented 7 years ago

I see it both during gulp's build-test (when it runs phantom, the latest build I installed to its own home today) and also when I open the html manually in Firefox (45.8.0, haven't tried other browsers). I currently run on Windows 7. At first I was thinking maybe it was a peculiarity of how the Windows file system was returning the order of dependencies in the glob ... but it's probably something in the goog closure-library not enforcing the require statement properly. Exactly how it works in the context of a single page is a little too much magic for me to figure out :)

By the way, glift is a beautiful package. Very nicely done. I was thinking of making a Moodle course for kids to learn go/baduk and wanted to design a plugin web app built on glift that could take some very simple problem types and produce examples so the kids could drill through quite a lot of them to earn badges. It's all non-commercial for a public school.