search

artasparks / gpub

GPub: Go Publishing for Glift
MIT License
16 stars 3 forks source link

Cropping sometimes ignores moves in a variation #38

Closed dormerod closed 8 years ago

dormerod commented 8 years ago

This seems to be an edge case and has proven very difficult to deliberately reproduce so far.

You can see the bug for yourself by processing this SGF with the following arguments:

--auto_box_crop_on_variation=true --region_restrictions=TOP,BOTTOM

The variation at the bottom of page 58 is missing Black 3.

artasparks commented 8 years ago

oh, ha. I think I know what the problem is.

artasparks commented 8 years ago

Totally rewrote the cropping logic. Let me know if you still see problems.