search

artasparks / gpub

GPub: Go Publishing for Glift
MIT License
16 stars 3 forks source link

Collision list should be compact even with only two collisions #48

Open dormerod opened 8 years ago

dormerod commented 8 years ago

Even when there are only two collisions (for one move each) in a variation, it's still better to put them all on the same line.

In practice, variations with a collision list tend to come in packets, because there's often more than one kind of ko, or there are multiple variations about the same ko. When you have multiple ko variations with a capture and a recapture (i.e. two collisions each) on the same page, the extra lines used push other variations onto the next page.

This was raised in #6 was well, but was probably explained poorly and was slightly different to the original issue.

The issue is mainly with variations, but if the same logic is applied to diagrams for simplicity, there's no problem.

artasparks commented 8 years ago

I'm leaning towards 'no' on this one. I don't like the combined style, but I tolerate its use occasionally for short-form yearbook style diagrams.

dormerod commented 8 years ago

I understand what you mean. I don't think the combined style looks best either.

The question then is whether it's a choice between the combined style or lots of white space; or whether it's possible to keep the current style for the collision list and fix the white space some other way.

Any thoughts?

We might review this again when Relentless is almost finished and you can have a look at the book.