search

artberri / rollup-plugin-istanbul

Seamless integration between Rollup and Istanbul
MIT License
43 stars 10 forks source link

Using latest versions of istanbul? #63

Open brettz9 opened 1 month ago

brettz9 commented 1 month ago

Expected Behavior

Not get errors when loading an instrumented file.

Current Behavior

I get errors about an unexpected semi-colon (due to missing parentheses).

Possible Solution

I don't know if perhaps rollup-plugin-istanbul is missing out on some patched updates (though maybe it is passing on a new buggy dependency).

Steps to Reproduce

  1. Clone https://github.com/es-joy/jsoe
  2. Install pnpm if not already and run pnpm install
  3. Run pnpm instrument
  4. Run pnpm start
  5. Open http://127.0.0.1:8087/demo/index-instrumented.html in the browser
  6. Notice the console error about a missing semi-colon.

Context (Environment)

I'm simply trying to instrument my files for use by Cypress.

Detailed Description

Please let me know if there is something more detailed I can provide.

Possible Implementation

Don't know.

brettz9 commented 1 month ago

I confirmed the issue occurs with an upgrade of rollup from 4.18.1 to 4.19.0.

brettz9 commented 1 month ago

So, not sure if this is an issue to report to rollup or to istanbul or to you?