search

artdarek / oauth-4-laravel

OAuth Service Provider for Laravel 4
684 stars 216 forks source link

Using Laravel Session #55

Open samvasko opened 10 years ago

samvasko commented 10 years ago

This package should probably be using session driver configured inside of app/config/session.php and not have separated configuration. For the benefit of flexibility and maintenance.

This means that OAuth\Common\Storage\TokenStorageInterface should be implemented using Illuminate\Session\Store

I will start poking into it now and see what I can come up with. What do you think?

sdeering commented 10 years ago

Hi @bliker did you manage to solve this?

ashleydw commented 10 years ago

+1. Confusing with the two separate configs

ashleydw commented 10 years ago

I have just implemented a rough version of this here:https://github.com/ashleydw/oauth-4-laravel/commit/cb4018054e0f0a617c84343e81949c49fec62970

I wouldn't suggest cloning my repo as I have bespoke requirements in there for other things, but you can take the commit out

no promises it works fully:)

samvasko commented 10 years ago

@sdeering Yep I did. Check out pull request on this repo. There is also another one from somebody else. My repo is here

sdeering commented 10 years ago

@bliker thanks mate.