artefactual-labs / mets-reader-writer

Library to parse and create METS files, especially for Archivematica.
https://mets-reader-writer.readthedocs.io
GNU Affero General Public License v3.0
20 stars 13 forks source link

Handle old Archivematica METS documents #53

Closed sevein closed 5 years ago

sevein commented 5 years ago

This pull request brings fixes for some issues found while trying to read METS documents generated by old versions of Archivematica.

Connects to https://github.com/archivematica/Issues/issues/24.

sevein commented 5 years ago

@cole, can you take a look?

I've added 1954131, this came up when I was updating https://github.com/artefactual/archivematica-storage-service/pull/438 so it uses metsrw. I've tweaked the FSEntry constructor a bit so it doesn't error.

Also, I'm going to need 22e17ff since the transfer METS is still using old-style fptrs. 22e17ff is going to be relevant in the future because AM needs to be able to work with old-style fptrs when importing vintage AIPs.

sevein commented 5 years ago

Uh this is not as easy as I thought...

sevein commented 5 years ago

Tests are passing but coverage decreased. I'll merge.