artefactual-labs / mets-reader-writer

Library to parse and create METS files, especially for Archivematica.
https://mets-reader-writer.readthedocs.io
GNU Affero General Public License v3.0
20 stars 13 forks source link

Add namespaces to PREMIS plugin to prevent ValueError: Invalid tag name on serialization #96

Closed tw4l closed 1 year ago

tw4l commented 2 years ago

Connected to https://github.com/artefactual-labs/mets-reader-writer/issues/94

This PR adds characterization tool namespaces to the PREMIS plugin's namespaces dictionaries to prevent serialization errors when serializing PREMISObjects that contain characterization tool output to XML.

This will enable adding raw PREMIS Object XML to the AIPscan database for files with characterization tool output.

Note that linting is currently failing because of the version of Black we are using. See: https://stackoverflow.com/questions/71673404/importerror-cannot-import-name-unicodefun-from-click. Upgrading Black to 22.3.0 also causes linting failures, as the newer version of Black wants us to drop explicit unicode strings (e.g. u"something"). I think that might be better handled in a separate PR.