artefactual-sdps / enduro

A tool to support ingest and automation in digital preservation workflows
https://enduro.readthedocs.io/
Apache License 2.0
4 stars 3 forks source link

Send PIPs to Archivematica as BagIt bags #1007

Closed djjuhasz closed 3 months ago

djjuhasz commented 3 months ago

Fixes #805

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 85.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 53.15%. Comparing base (17ae315) to head (6471106). Report is 65 commits behind head on main.

Files with missing lines Patch % Lines
internal/workflow/processing.go 87.09% 4 Missing and 4 partials :warning:
cmd/enduro-am-worker/main.go 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1007 +/- ## ========================================== + Coverage 53.12% 53.15% +0.03% ========================================== Files 102 102 Lines 5835 5856 +21 ========================================== + Hits 3100 3113 +13 - Misses 2478 2484 +6 - Partials 257 259 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

djjuhasz commented 3 months ago

@jraddaoui okay, I've addressed your comments and the workflow will now stop if preprocessing returns a SIP that is not a bag. I also had to fight with prettier a bit about formatting markdown, and made some changes to the preprocessing_test script to get the preprocessing test working and for my sanity trying to figure out where preservation tasks are being created and completed.

I'll squash all the changes before merging.