search

artefactual-sdps / enduro

A tool to support ingest and automation in digital preservation workflows
https://enduro.readthedocs.io/
Apache License 2.0
4 stars 3 forks source link

Use tabs to filter the package list by status #1055

Closed djjuhasz closed 3 weeks ago

djjuhasz commented 1 month ago

Refs #989.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.48%. Comparing base (37c59a9) to head (edb5d31). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1055 +/- ## ========================================== - Coverage 54.56% 54.48% -0.08% ========================================== Files 103 103 Lines 7510 7510 ========================================== - Hits 4098 4092 -6 - Misses 3163 3167 +4 - Partials 249 251 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

djjuhasz commented 1 month ago

Screenshot: image

jraddaoui commented 1 month ago

@djjuhasz, I'm out tomorrow but some early feedback.

I just realized we already have a tabs component with links and icons that is even "responsive", it's used from the location index page. It would be nice to tweak that one a bit to make it work in this case, maybe accepting a parameter in the URLs or something like that:

https://github.com/artefactual-sdps/enduro/blob/main/dashboard/src/components/Tabs.vue https://github.com/artefactual-sdps/enduro/blob/main/dashboard/src/pages/locations/%5Bid%5D.vue#L22-L41 https://github.com/artefactual-sdps/enduro/blob/main/dashboard/src/pages/locations/%5Bid%5D.vue#L54

image image

djjuhasz commented 1 month ago

Having to scroll horizontally on a phone to click a tab seems like a terrible UI experience to me. :confused:

djjuhasz commented 3 weeks ago

@jraddaoui this is ready for another look. :pray: