artefactual-sdps / enduro

A tool to support ingest and automation in digital preservation workflows
https://enduro.readthedocs.io/
Apache License 2.0
4 stars 3 forks source link

Use a3m shareDir config value in processing #865

Closed djjuhasz closed 4 months ago

djjuhasz commented 4 months ago

Refs #864

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 46.00%. Comparing base (b0e5362) to head (6f286a7). Report is 2 commits behind head on main.

Files Patch % Lines
main.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #865 +/- ## ========================================== + Coverage 45.33% 46.00% +0.66% ========================================== Files 93 94 +1 Lines 5036 5065 +29 ========================================== + Hits 2283 2330 +47 + Misses 2551 2533 -18 Partials 202 202 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

djjuhasz commented 4 months ago

Commit eca89b656e9e4b825acae07b50230aa73cbe7732 fixes a hardcoded a3m shared directory path in Enduro, but the processing workflow is still failing if the path is changed from the default. A3m finds the deposited SIP in the new path, and succesfully creates and AIP, but a3m is still saving the final AIP to the default "/home/a3m/.local/share/a3m/share/" directory instead of the new path. A3m doesn't pass the stored AIP path back to Enduro directly so Enduro is assuming the path of the AIP is "/home/a3m/.local/share/a3m/new_share/completed", which is not correct.

Fixing this completely will require changes to a3m.